Fix confusing error when providing fields that don't exist to `ui.car…

…dFields`, `ui.inlineCreate.fields` and `ui.inlineEdit.fields` in relationship field (keystonejs#6045)

* Fix confusing error when providing fields that don't exist to `ui.cardFields`, `ui.inlineCreate.fields` and `ui.inlineEdit.fields`

* Fix some things

* words

.changeset/late-comics-fail.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': patch
+---
+
+Adjusted when `getAdminMeta` is called on fields so that they can see the metadata (excluding the results of `getAdminMeta` on fields) of other fields to do validation or etc.

.changeset/nasty-pugs-repair.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/fields': patch
+---
+
+Fixed confusing error when providing fields that don't exist to `ui.cardFields`, `ui.inlineCreate.fields` and `ui.inlineEdit.fields`.

packages-next/fields/src/types/relationship/index.ts

@@ -84,6 +84,33 @@ export const relationship =
             `The ref [${ref}] on relationship [${meta.listKey}.${meta.fieldKey}] is invalid`
           );
         }
+        if (config.ui?.displayMode === 'cards') {
+          // we're checking whether the field which will be in the admin meta at the time that getAdminMeta is called.
+          // in newer versions of keystone, it will be there and it will not be there for older versions of keystone.
+          // this is so that relationship fields doesn't break in confusing ways
+          // if people are using a slightly older version of keystone
+          const currentField = adminMetaRoot.listsByKey[meta.listKey].fields.find(
+            x => x.path === meta.fieldKey
+          );
+          if (currentField) {
+            const allForeignFields = new Set(
+              adminMetaRoot.listsByKey[foreignListKey].fields.map(x => x.path)
+            );
+            for (const [configOption, foreignFields] of [
+              ['ui.cardFields', config.ui.cardFields],
+              ['ui.inlineCreate.fields', config.ui.inlineCreate?.fields ?? []],
+              ['ui.inlineEdit.fields', config.ui.inlineEdit?.fields ?? []],
+            ] as const) {
+              for (const foreignField of foreignFields) {
+                if (!allForeignFields.has(foreignField)) {
+                  throw new Error(
+                    `The ${configOption} option on the relationship field at ${meta.listKey}.${meta.fieldKey} includes the "${foreignField}" field but that field does not exist on the "${foreignListKey}" list`
+                  );
+                }
+              }
+            }
+          }
+        }
         return {
           refListKey: foreignListKey,
           many,

packages-next/keystone/src/admin-ui/system/createAdminMeta.ts

@@ -85,13 +85,22 @@ export function createAdminMeta(
         label: field.label ?? humanize(fieldKey),
         viewsIndex: getViewId(field.views),
         customViewsIndex: field.ui?.views === undefined ? null : getViewId(field.ui.views),
-        fieldMeta: field.getAdminMeta?.(adminMetaRoot) ?? null,
+        fieldMeta: null,
         isOrderable: !!field.input?.orderBy,
         path: fieldKey,
         listKey: key,
       });
     }
   }
 
+  // we do this seperately to the above so that fields can check other fields to validate their config or etc.
+  // (ofc they won't necessarily be able to see other field's fieldMeta)
+  for (const [key, list] of Object.entries(initialisedLists)) {
+    for (const fieldMetaRootVal of adminMetaRoot.listsByKey[key].fields) {
+      fieldMetaRootVal.fieldMeta =
+        list.fields[fieldMetaRootVal.path].getAdminMeta?.(adminMetaRoot) ?? null;
+    }
+  }
+
   return adminMetaRoot;
 }