Use setuptools_scm to generate package version #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now seems all OK |
gotmax23
commented
Feb 23, 2024
There was a problem hiding this comment.
I would suggest completely removing __version__.py from source control and adding it to .gitiginore over having a placeholder file. Otherwise, running, for example, python -m build, will modify the file in place and create a dirty git checkout.
There was a problem hiding this comment.
I would suggest completely removing
__version__.pyfrom source control
Currently, the only option available is:
- Leave
__version__.pyin place, but add it to .gitiginore
To prevent changes to this file from being recorded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8