Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5 Migration With Backwards Compatibility #54

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

gtrop1
Copy link
Contributor

@gtrop1 gtrop1 commented Apr 30, 2019

No description provided.

@gtrop1 gtrop1 added this to the 5.2.0 milestone Apr 30, 2019
@gtrop1 gtrop1 requested a review from cnoon April 30, 2019 19:13
@gtrop1 gtrop1 force-pushed the gt/swift-5-migration branch from 3ff55a8 to bcfb588 Compare April 30, 2019 20:19
@cnoon cnoon self-assigned this Apr 30, 2019
@cnoon cnoon added the swift label Apr 30, 2019
Copy link
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things. We'll also need to get the package files updated.

Gemfile Outdated Show resolved Hide resolved
Willow.podspec Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@gtrop1 gtrop1 force-pushed the gt/swift-5-migration branch from bcfb588 to ecbfd98 Compare April 30, 2019 21:14
Copy link
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more things.

[email protected] Outdated Show resolved Hide resolved
Package.swift Outdated
.target(name: "Willow", path: "", sources: ["Source"])
.target(
name: "Willow",
path: "Source")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could one-line these if you wanted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to one line

Gemfile.lock Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
@gtrop1 gtrop1 force-pushed the gt/swift-5-migration branch from ecbfd98 to a06fd29 Compare April 30, 2019 21:50
@gtrop1 gtrop1 merged commit 01521b8 into master Apr 30, 2019
@gtrop1 gtrop1 deleted the gt/swift-5-migration branch April 30, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants