Deprecate Optional<Logger> extensions #42
Conversation
| @@ -50,6 +50,9 @@ open class Logger { | |||
|
|
|||
| // MARK: - Properties | |||
|
|
|||
| /// A logger that does not output any messages to writers. | |||
| public static let disabled: Logger = NoOpLogger() | |||
There was a problem hiding this comment.
This is an awesome change, but it's not backwards compatible. Are you thinking this should go out as Willow 6? If yes, then I'd recommend that we deprecate the optional APIs for now and add the disabled Logger. Then we commit this into a willow6 branch or something for when we're ready to lump more breaking changes into it. Thoughts?
There was a problem hiding this comment.
If we are considering a major version bump, there are other things I'd like us to consider. The Writer API feels clunky and I would want to maybe take another look at how os_log and os_signpost work these days and see if there is anything for us to learn from. I also think the default ConsoleWriter could have cleaner output... it's the first thing I replace every time I use Willow...
Source/Logger.swift
Outdated
| final private class NoOpLogger: Logger { | ||
| init() { | ||
| super.init(logLevels: .off, writers: []) | ||
| enabled = false | ||
| } |
ejensen
force-pushed
the
remove-optional-extensions
branch
from
d64b8e1 to
23421b3
Compare
Encourage using non-optional log variables that are can be assigned to .disabled. This mimics the OSLog API
ejensen
force-pushed
the
remove-optional-extensions
branch
from
23421b3 to
eca5c61
Compare
ejensen
changed the title
Deprecates
Optional<Logger>extensions.This encourage the use of non-optional log
vars. Which can be assigned to.disabled.This mimics the OSLog API.
The migration is simple:
var log: Logger?→var log: Logger = .disabled.