-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 10 and Swift 4.2 Support #10
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
742d5b9
Updated the Xcode project and podspec to Xcode 10 and Swift 4.2
cnoon 5c7a3dd
Added a .ruby-version file to ruby gems
cnoon 54b96f7
Updated podspec to use double quotes throughout
cnoon cd03e9c
Disabled code signing on test targets
cnoon dd91288
Enabled code coverage on all non-ci schemes
cnoon 2e57470
Added Gemfile and Gemfile.lock to the project along with Ruby 2.4.3
cnoon 2018e41
Updated travis-ci yaml file to use bundler and Xcode 10
cnoon 524f3b4
Updated the connection pool test to be more robust on CI
cnoon fa32d3a
Added release notes to the CHANGELOG and bumped the version to 3.2.1
cnoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
2.4.3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
source "https://rubygems.org" | ||
|
||
gem "cocoapods", "~> 1.6.0.beta.1" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to run the 1.6 beta in order to avoid some odd code signing errors. |
||
gem "xcpretty" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
GEM | ||
remote: https://rubygems.org/ | ||
specs: | ||
CFPropertyList (3.0.0) | ||
activesupport (4.2.10) | ||
i18n (~> 0.7) | ||
minitest (~> 5.1) | ||
thread_safe (~> 0.3, >= 0.3.4) | ||
tzinfo (~> 1.1) | ||
atomos (0.1.3) | ||
claide (1.0.2) | ||
cocoapods (1.6.0.beta.1) | ||
activesupport (>= 4.0.2, < 5) | ||
claide (>= 1.0.2, < 2.0) | ||
cocoapods-core (= 1.6.0.beta.1) | ||
cocoapods-deintegrate (>= 1.0.2, < 2.0) | ||
cocoapods-downloader (>= 1.2.1, < 2.0) | ||
cocoapods-plugins (>= 1.0.0, < 2.0) | ||
cocoapods-search (>= 1.0.0, < 2.0) | ||
cocoapods-stats (>= 1.0.0, < 2.0) | ||
cocoapods-trunk (>= 1.3.1, < 2.0) | ||
cocoapods-try (>= 1.1.0, < 2.0) | ||
colored2 (~> 3.1) | ||
escape (~> 0.0.4) | ||
fourflusher (~> 2.0.1) | ||
gh_inspector (~> 1.0) | ||
molinillo (~> 0.6.6) | ||
nap (~> 1.0) | ||
ruby-macho (~> 1.2) | ||
xcodeproj (>= 1.6.0, < 2.0) | ||
cocoapods-core (1.6.0.beta.1) | ||
activesupport (>= 4.0.2, < 6) | ||
fuzzy_match (~> 2.0.4) | ||
nap (~> 1.0) | ||
cocoapods-deintegrate (1.0.2) | ||
cocoapods-downloader (1.2.1) | ||
cocoapods-plugins (1.0.0) | ||
nap | ||
cocoapods-search (1.0.0) | ||
cocoapods-stats (1.0.0) | ||
cocoapods-trunk (1.3.1) | ||
nap (>= 0.8, < 2.0) | ||
netrc (~> 0.11) | ||
cocoapods-try (1.1.0) | ||
colored2 (3.1.2) | ||
concurrent-ruby (1.0.5) | ||
escape (0.0.4) | ||
fourflusher (2.0.1) | ||
fuzzy_match (2.0.4) | ||
gh_inspector (1.1.3) | ||
i18n (0.9.5) | ||
concurrent-ruby (~> 1.0) | ||
minitest (5.11.3) | ||
molinillo (0.6.6) | ||
nanaimo (0.2.6) | ||
nap (1.1.0) | ||
netrc (0.11.0) | ||
rouge (2.0.7) | ||
ruby-macho (1.2.0) | ||
thread_safe (0.3.6) | ||
tzinfo (1.2.5) | ||
thread_safe (~> 0.1) | ||
xcodeproj (1.6.0) | ||
CFPropertyList (>= 2.3.3, < 4.0) | ||
atomos (~> 0.1.3) | ||
claide (>= 1.0.2, < 2.0) | ||
colored2 (~> 3.1) | ||
nanaimo (~> 0.2.6) | ||
xcpretty (0.3.0) | ||
rouge (~> 2.0.7) | ||
|
||
PLATFORMS | ||
ruby | ||
|
||
DEPENDENCIES | ||
cocoapods (~> 1.6.0.beta.1) | ||
xcpretty | ||
|
||
BUNDLED WITH | ||
1.16.4 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,19 @@ | ||
Pod::Spec.new do |s| | ||
s.name = 'SQift' | ||
s.version = '3.2.0' | ||
s.license = 'MIT' | ||
s.summary = 'A lightweight Swift wrapper for SQLite.' | ||
s.homepage = 'https://github.com/Nike-Inc/SQift' | ||
s.authors = { 'Dave Camp' => '[email protected]', 'Christian Noon' => '[email protected]' } | ||
s.name = "SQift" | ||
s.version = "3.2.1" | ||
s.license = "MIT" | ||
s.summary = "A lightweight Swift wrapper for SQLite." | ||
s.homepage = "https://github.com/Nike-Inc/SQift" | ||
s.authors = { "Dave Camp" => "[email protected]", "Christian Noon" => "[email protected]" } | ||
|
||
s.source = { :git => 'https://github.com/Nike-Inc/SQift.git', :tag => s.version } | ||
s.source_files = 'Source/**/*.swift' | ||
s.swift_version = '4.1' | ||
s.source = { :git => "https://github.com/Nike-Inc/SQift.git", :tag => s.version } | ||
s.source_files = "Source/**/*.swift" | ||
s.swift_version = "4.2" | ||
|
||
s.ios.deployment_target = '9.0' | ||
s.osx.deployment_target = '10.11' | ||
s.tvos.deployment_target = '9.0' | ||
s.watchos.deployment_target = '2.0' | ||
s.ios.deployment_target = "9.0" | ||
s.osx.deployment_target = "10.11" | ||
s.tvos.deployment_target = "9.0" | ||
s.watchos.deployment_target = "2.0" | ||
|
||
s.libraries = 'sqlite3' | ||
s.libraries = "sqlite3" | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifying the
sdk
can cause some issues. Best to remove it and rely on the settings in the Xcode project.