-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codacy warning fixes #65
Conversation
Fixes line width in python documentation, markdown bullet point spacing, and default nonTOF_distance_threshold in consistency test to 0.f
@KrisThielemans, can you take a look and confirm these changes? |
thanks! Looks good to me. Tests are running, but will work of course. sadly, Codacy isn't running on this repo. Maybe you can run it manually through the markdown checker? |
I am not 100% sure what markdown checker you are referring too but Prettier should handle it. It also matched the results of this one https://webutility.io/markdown-beautifier. |
great. thanks. Codacy recommended another one, but I'm sure this is fine. |
This PR did not seem to resolve the issue. https://app.codacy.com/gh/UCL/STIR/pullRequest?prid=12651966 |
I don't understand why (1.)
(line 12) fails because of "Spacing between a list item’s bullet and its content violates a given style" while (2.)
(line 25) is okay...
fails for the same reason. |
Ah well. Codacy is apprently using https://github.com/remarkjs/remark-lint I see the following full message on Codacy
So, I guess we could try and run remark offline, or configure it appropriately, or... ignore the rule, as it displays just fine. I'm ok with the latter option, as there's more important things in life, but let me know what you want to do. |
IMO, it is being too strict on a trivial issue for a non pre-commit enforcing change. If this can be ignored, let's just. do that. |
Looks like Codacy still isn't happy about the constructor either. Oh well. Not sure why. I'll ignore. |
That one makes no sense to me because it's value is set with this PR and, if it wasn't, codacy should warn about some others too. I'm sorry, I don't understand. |
nonTOF_distance_threshold
in consistency test to0.f