Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove defaults for some TOF-ranges to avoid unexpected problems #64

Merged
merged 1 commit into from
Jan 4, 2024
Merged

remove defaults for some TOF-ranges to avoid unexpected problems #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/include/stir/recon_buildblock/DataSymmetriesForBins.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,7 @@ class DataSymmetriesForBins : public DataSymmetriesForViewSegmentNumbers
virtual ~DataSymmetriesForBins();

virtual
#ifndef STIR_NO_COVARIANT_RETURN_TYPES
DataSymmetriesForBins
#else
DataSymmetriesForViewSegmentNumbers
#endif
* clone() const = 0;
DataSymmetriesForBins * clone() const = 0;

#if 0
TODO!
Expand All @@ -109,7 +104,7 @@ class DataSymmetriesForBins : public DataSymmetriesForViewSegmentNumbers
get_related_bins(std::vector<Bin>&, const Bin& b,
const int min_axial_pos_num, const int max_axial_pos_num,
const int min_tangential_pos_num, const int max_tangential_pos_num,
const int min_timing_pos_num = 0, const int max_timing_pos_num = 0) const;
const int min_timing_pos_num, const int max_timing_pos_num) const;

//! fills in a vector with the axial and tangential position numbers related to this bin
/*! range for axial_pos_num and tangential_pos_num is taken from the ProjDataInfo object
Expand Down
9 changes: 2 additions & 7 deletions src/include/stir/recon_buildblock/TrivialDataSymmetriesForBins.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,13 @@ class TrivialDataSymmetriesForBins : public DataSymmetriesForBins
TrivialDataSymmetriesForBins(const shared_ptr<const ProjDataInfo>& proj_data_info_ptr);

virtual
#ifndef STIR_NO_COVARIANT_RETURN_TYPES
TrivialDataSymmetriesForBins
#else
DataSymmetriesForViewSegmentNumbers
#endif
* clone() const;
TrivialDataSymmetriesForBins * clone() const;

virtual void
get_related_bins(std::vector<Bin>&, const Bin& b,
const int min_axial_pos_num, const int max_axial_pos_num,
const int min_tangential_pos_num, const int max_tangential_pos_num,
const int min_timing_pos_num = 0, const int max_timing_pos_num = 0) const;
const int min_timing_pos_num, const int max_timing_pos_num0) const;

virtual void
get_related_bins_factorised(std::vector<AxTangPosNumbers>&, const Bin& b,
Expand Down
2 changes: 1 addition & 1 deletion src/include/stir/recon_buildblock/distributable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ void distributable_computation(
const double end_time_of_frame,
RPC_process_related_viewgrams_type * RPC_process_related_viewgrams,
DistributedCachingInformation* caching_info_ptr,
int min_timing_pos_num = 0, int max_timing_pos_num = 0);
int min_timing_pos_num, int max_timing_pos_num);

/*!
\brief This function essentially implements a loop over a cached listmode file
Expand Down
2 changes: 1 addition & 1 deletion src/include/stir/recon_buildblock/distributableMPICacheEnabled.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ void distributable_computation_cache_enabled(
const double end_time_of_frame,
RPC_process_related_viewgrams_type * RPC_process_related_viewgrams,
DistributedCachingInformation* caching_info_ptr,
int min_timing_pos_num = 0, int max_timing_pos_num = 0
int min_timing_pos_num, int max_timing_pos_num
);


Expand Down