update rxandroidble2 to 1.12.1 #1723
Conversation
tolot27
force-pushed
the
dependabot/gradle/com.polidea.rxandroidble2-rxandroidble-1.12.1
branch
2 times, most recently
from
c5839d6 to
a508b82
Compare
Bumps [rxandroidble](https://github.com/Polidea/RxAndroidBle) from 1.11.1 to 1.12.1. - [Release notes](https://github.com/Polidea/RxAndroidBle/releases) - [Changelog](https://github.com/Polidea/RxAndroidBle/blob/master/CHANGELOG.md) - [Commits](https://github.com/Polidea/RxAndroidBle/commits) Signed-off-by: dependabot[bot] <[email protected]>
tolot27
force-pushed
the
dependabot/gradle/com.polidea.rxandroidble2-rxandroidble-1.12.1
branch
from
a508b82 to
76baf40
Compare
No, I don't think so. I cannot test it because Bluetooth/Dexcom is not available in the simulator and I don't have a device which is capable of running Android 12. BTW: It is running fine on my S4 (Android 10) for three days, so far. |
Thank you for your reply. In fact only stopped working on Pixel 4a 5G after the Preview 3 version of Android 12, as soon I reverted to Android 11 started working right away. |
|
@jwoglom Please can you review this PR as well? |
There was a problem hiding this comment.
@tolot27 Built an APK from this PR and tested it out on my old Pixel 2XL running Android 10, and it seems to function OK connecting to a G6 transmitter. I did run into some awkward behavior when initially pairing a transmitter, but I've run into that with stock xDrip before so I doubt it's related.
|
@jwoglom thanks for testing. It runs well on my phone for several days. During transmitter change it took a while to bond. But that also happens with the nightly build and no extra message is logged. Hence, it is unrelated to rxble. |
|
I'll try this out here and see if it looks like everything still works okay. |
|
The testing I've been doing with this has worked well over a range of handsets so I think its good to be merged. |
dependabot
bot
deleted the
dependabot/gradle/com.polidea.rxandroidble2-rxandroidble-1.12.1
branch
tolot27
restored the
dependabot/gradle/com.polidea.rxandroidble2-rxandroidble-1.12.1
branch
tolot27
deleted the
dependabot/gradle/com.polidea.rxandroidble2-rxandroidble-1.12.1
branch
This PR bumps RxAndroidBle to version 1.12.1 to fix a memory leak in scanBleDevices which can cause the RxAndroidBle stack to hang.
It also add support to parse service solicitation UUIDs, which is required by the updated library but currently not used in xDrip.