refactor: Improve start up #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change creates a new state variable 'appReady'. This is true when the state has hydrated and both the custom item defintion and bungie definitions have all successfully been downloaded or on app restart loaded. The MainDrawer UI will not be shown till the app is ready making it impossible for the auto refresh or manual refresh to be activated. The splash screen is then only hidden when the app is ready. And exception to this is when the app is not authenticated. In this case the splash is dimissed and then the login screen is shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a new state variable 'appReady'. This is true when the state has hydrated and both the custom item defintion and bungie definitions have all successfully been downloaded or on app restart loaded.
The MainDrawer UI will not be shown till the app is ready making it impossible for the auto refresh or manual refresh to be activated.
The splash screen is then only hidden when the app is ready. And exception to this is when the app is not authenticated. In this case the splash is dimissed and then the login screen is shown.