fix: missing special orders buckethash (#826)

NigelBreslaw · Mar 14, 2024 · f12e354 · f12e354
1 parent cea6d02
commit f12e354
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/native/ReleaseNotes/whatsnew-en b/native/ReleaseNotes/whatsnew-en
@@ -1 +1 @@
-Web release notes..
+Web release notes...
diff --git a/native/app/bungie/Types.ts b/native/app/bungie/Types.ts
@@ -15,7 +15,8 @@ export type CharacterGear = {
   equipped: DestinyItem | null;
   inventory: Array<DestinyItem>;
 };
-export type VaultBucketHash = 138197802 | 1469714392 | 3313201758;
+export type VaultBucketHash = 138197802 | 1469714392 | 3313201758 | 1367666825;
+export const vaultBucketHashes = [138197802, 1469714392, 3313201758, 1367666825];
 
 export type VaultData = {
   characterId: string;
@@ -33,6 +34,10 @@ export type VaultData = {
     3313201758: {
       items: Record<number, CharacterGear>;
     };
+    // special orders:
+    1367666825: {
+      items: Record<number, CharacterGear>;
+    };
   };
 };
 

diff --git a/native/app/core/DataService.ts b/native/app/core/DataService.ts
@@ -1,6 +1,6 @@
 import { getCustomItemDefinition } from "@/app/backend/api.ts";
 import { getProfile } from "@/app/bungie/BungieApi.ts";
-import { type ProfileData, getProfileSchema } from "@/app/bungie/Types.ts";
+import { type ProfileData, getProfileSchema, vaultBucketHashes } from "@/app/bungie/Types.ts";
 import type { CharactersAndVault, DestinyItem, VaultBucketHash } from "@/app/bungie/Types.ts";
 import { type ItemDefinition, ItemDefinitionSchema, type SingleItemDefinition } from "@/app/core/Types.ts";
 import type { GlobalAction } from "@/app/state/Types.ts";
@@ -28,6 +28,10 @@ class DataService {
         3313201758: {
           items: {},
         },
+        // special orders:
+        1367666825: {
+          items: {},
+        },
       },
     },
     characters: {},
@@ -187,23 +191,23 @@ class DataService {
 
       for (const item of vaultInventory) {
         const itemHash = item.itemHash.toString();
-        console.log("itemHash", itemHash);
         const data = DataService.itemDefinition.items[itemHash] as SingleItemDefinition;
 
         const bucketHashIndex = data.b;
         if (bucketHashIndex) {
           const definitionBucketHash = DataService.bucketTypeHashArray[bucketHashIndex];
 
           if (definitionBucketHash) {
-            console.log("Found bucket", definitionBucketHash);
-            console.log("item.bucketHash", item.bucketHash);
+            if (!vaultBucketHashes.includes(item.bucketHash)) {
+              console.error("item.bucketHash not in vaultBucketHashes", item.bucketHash);
+              continue;
+            }
             const hasBucket = Object.hasOwn(vaultItems[item.bucketHash as VaultBucketHash].items, definitionBucketHash);
             if (!hasBucket) {
               vaultItems[item.bucketHash as VaultBucketHash].items[definitionBucketHash] = {
                 equipped: null,
                 inventory: [],
               };
-              console.log("Added new bucket", item.bucketHash, definitionBucketHash);
             }
 
             vaultItems[item.bucketHash as VaultBucketHash].items[definitionBucketHash]?.inventory.push(item);