refactor: Simplify primaryStat so its only a number (#1232)

NigelBreslaw · Apr 12, 2024 · 6c9e357 · 6c9e357
1 parent 1f56534
commit 6c9e357
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/native/app/inventory/Common.ts b/native/app/inventory/Common.ts
@@ -100,7 +100,7 @@ export type DestinyIconData = {
   characterId: string;
   icon: string;
   damageTypeIconUri: number | null;
-  primaryStat: string;
+  primaryStat: number;
   quantity: number;
   calculatedWaterMark: string | undefined;
   masterwork: boolean;

diff --git a/native/app/inventory/DestinyCell.tsx b/native/app/inventory/DestinyCell.tsx
@@ -154,7 +154,7 @@ const DestinyCell = (props: DestinyCellProps) => {
               {props.data.crafted && <Image source={CRAFTED_OVERLAY} cachePolicy="memory" style={styles.crafted} />}
             </View>
           </View>
-          {props.data.primaryStat !== "" && (
+          {props.data.primaryStat > 0 && (
             <View style={styles.primaryStat}>
               <Text style={styles.primaryStatText}>{props.data.primaryStat}</Text>
             </View>

diff --git a/native/app/inventory/EngramCell.tsx b/native/app/inventory/EngramCell.tsx
@@ -64,7 +64,7 @@ const EngramCell = (props: DestinyCellProps) => {
             style={styles.frameSize}
             recyclingKey={props.data?.icon}
           />
-          {props.data?.primaryStat !== "" && props.data?.primaryStat && (
+          {props.data?.primaryStat && props.data?.primaryStat > 0 && (
             <View style={styles.primaryStat}>
               <Text style={styles.powerLevelText}>{props.data?.primaryStat}</Text>
             </View>

diff --git a/native/app/store/AccountInventoryLogic.ts b/native/app/store/AccountInventoryLogic.ts
@@ -199,7 +199,7 @@ function returnVaultUiData(itemBuckets: number[], vaultData: VaultData): UISecti
 
 function returnDestinyIconData(item: DestinyItem): DestinyIconData {
   const damageTypeIconUri = getDamageTypeIconUri(item.damageType);
-  const primaryStat = item.primaryStat > 0 ? item.primaryStat.toString() : "";
+  const primaryStat = item.primaryStat;
   const borderColor = returnBorderColor(item);
   const masterwork = item.masterwork ?? false;
   const crafted = item.crafted;