fix: Crash on missing DestinyStatDefinition (#2082)

NigelBreslaw · Jul 19, 2024 · 6b627f5 · 6b627f5
1 parent 04e088e
commit 6b627f5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/native/app/inventory/pages/details/ScreenInfo.tsx b/native/app/inventory/pages/details/ScreenInfo.tsx
@@ -120,10 +120,10 @@ export default function ScreenInfo({ destinyItem }: Props) {
 
 function getPrimaryStatLabel(destinyItem: DestinyItem): string {
   if (destinyItem.def.itemType === ItemType.Weapon) {
-    return DestinyStatDefinition[StatType.Power]?.displayProperties.name ?? "";
+    return DestinyStatDefinition?.[StatType.Power]?.displayProperties.name ?? "";
   }
   if (destinyItem.def.itemType === ItemType.Vehicle) {
-    return DestinyStatDefinition[StatType.Speed]?.displayProperties.name ?? "";
+    return DestinyStatDefinition?.[StatType.Speed]?.displayProperties.name ?? "";
   }
   return "";
 }

diff --git a/native/app/stats/StatBars.tsx b/native/app/stats/StatBars.tsx
@@ -201,7 +201,7 @@ function getName(statType: StatType) {
     case StatType.Separator:
       return "";
     default:
-      return DestinyStatDefinition[statType]?.displayProperties.name ?? "";
+      return DestinyStatDefinition?.[statType]?.displayProperties.name ?? "";
   }
 }
 

diff --git a/native/app/utilities/Constants.ts b/native/app/utilities/Constants.ts
@@ -12,7 +12,7 @@ export function updateBucketSizes() {
 }
 
 export function updateDestinyText() {
-  DESTINY_TEXT.POWER = DestinyStatDefinition[1935470627]?.displayProperties.name ?? "";
+  DESTINY_TEXT.POWER = DestinyStatDefinition?.[1935470627]?.displayProperties.name ?? "";
 }
 
 export const VAULT_CHARACTER_ID = "VAULT" as CharacterId;