This repository has been archived by the owner on Nov 11, 2021. It is now read-only.
Add bash script to check driver on some distros. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
done 👍 |
|
There is some stuff that I dislike in the script. It tries to install the driver evenif the vainfo which is very instrusive if we widespread this script for all community. A better approach would be to test vainfo, and if it is not optimal, it checks if all the appropriate drivers are installed. If not, it asks to actually install them and recheck. Moreover, a small warning about why we use |
aquadzn
commented
Apr 30, 2020
aquadzn
commented
Apr 30, 2020
aquadzn
commented
Apr 30, 2020
aquadzn
commented
Apr 30, 2020
aquadzn
commented
Apr 30, 2020
aquadzn
commented
Apr 30, 2020
aquadzn
commented
Apr 30, 2020
aquadzn
commented
Apr 30, 2020
There was a mistake on the test.
Fedora test for vainfo
NicolasGuilloux
suggested changes
Apr 30, 2020
aquadzn
commented
Apr 30, 2020
*Total -- 1,216.68kb -> 1,009.54kb (17.03%) /docs/assets/css/images/overlay.png -- 19.63kb -> 2.76kb (85.95%) /docs/images/logo.png -- 27.42kb -> 17.03kb (37.89%) /docs/images/share_folder.png -- 354.91kb -> 248.44kb (30%) /docs/images/appimage.png -- 22.24kb -> 17.33kb (22.08%) /docs/images/hamachi_virtualhere.png -- 118.13kb -> 93.61kb (20.76%) /docs/images/dolphin_share.png -- 53.87kb -> 44.56kb (17.29%) /docs/images/hamachi_config.png -- 90.20kb -> 76.13kb (15.59%) /docs/images/hamachi_virtualhere_linux.png -- 54.47kb -> 46.25kb (15.09%) /docs/images/shadow-tool.png -- 24.08kb -> 20.71kb (14%) /docs/assets/css/styles/brown-papersq.png -- 17.77kb -> 17.36kb (2.32%) /docs/assets/fonts/fontawesome-webfont.svg -- 433.96kb -> 425.36kb (1.98%) Signed-off-by: ImgBotApp <[email protected]>
Reduce images total size by 17%
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.