Attempt to mitigate allocations in structured rendering

Nickztar · Jan 15, 2024 · 2d8734c · 2d8734c
1 parent 2f48591
commit 2d8734c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/Serilog.Sinks.LogtailSys/Formatters/LogtailFormatter.cs b/Serilog.Sinks.LogtailSys/Formatters/LogtailFormatter.cs
@@ -111,12 +111,10 @@ private string GetMessageId(LogEvent logEvent)
 
         private string RenderStructuredData(LogEvent logEvent)
         {
-            var properties = logEvent.Properties.Select(kvp =>
-                new KeyValuePair<string, string>(RenderPropertyKey(kvp.Key), RenderPropertyValue(kvp.Value)));
             var tokenPart = $"{tokenKey}=\"{token}\"";
-            var structuredDataKvps = string.Join(" ", properties.Select(t => $"""
-                                                                              {t.Key}="{t.Value}"
-                                                                              """));
+            var structuredDataKvps = string.Join(" ", logEvent.Properties.Select(t => $"""
+                {RenderPropertyKey(t.Key)}="{RenderPropertyValue(t.Value)}"
+                """));
             var structuredData = string.IsNullOrEmpty(structuredDataKvps) ? $"[{tokenPart}]" : $"[{tokenPart}][{dataName} {structuredDataKvps}]";
 
             return structuredData;

diff --git a/Serilog.Sinks.LogtailSys/Serilog.Sinks.LogtailSys.csproj b/Serilog.Sinks.LogtailSys/Serilog.Sinks.LogtailSys.csproj
@@ -5,7 +5,7 @@
     <Description>Fully-featured Serilog sink that logs events to logtail using UDP (rSyslog).</Description>
     <Authors>Nicholas Brostrom (Nickztar)</Authors>
     <Company>Effectsoft AB</Company>
-    <VersionPrefix>1.0.4</VersionPrefix>
+    <VersionPrefix>1.0.5</VersionPrefix>
     <Nullable>enable</Nullable>
     <LangVersion>latest</LangVersion>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>