InvalidPackage has msg and package_path #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 30, 2018 22:13
…tr__' Note that `parse_package_string` catches InvalidPackage exception and sets the filename; it is needed because the functions that called in `_parse_package_string` raise InvalidPackage exception without filename, e.g. `_get_node`
…sertEqual(None, ...)``
Nickolaim
changed the title
InvalidPackage has msg andpackage_path
Nickolaim
added a commit
that referenced
this pull request
May 3, 2018
* `parse_package_string()` raises `InvalidPackage` exception with the package name in the message. This work is needed for [https://github.com/ros-infrastructure/rosdep/issues/598](https://github.com/ros-infrastructure/rosdep/issues/598) * Add filename to the InvalidPackage exception coming from `Package.validate()` * `InvalidPackage` has `msg` and`package_path` (#1) `InvalidPackage` exception has `msg`, `package_path` and defines `__str__()` Note that `parse_package_string()` catches `InvalidPackage` exception and sets the filename; it is needed because the functions that called in `_parse_package_string()` raise InvalidPackage exception without filename, e.g. `_get_node()` * Minor code review fixes - Use double quotes for string literals with single quotes inside - Use forward slash instead of backward slash in file path * Pass filename to functions that raise InvalidPackage Remove not used `_get_optional_node_value()` Remove try/except block that was adding filename to InvalidPackage exception * nipick: improve error message
Nickolaim
added a commit
that referenced
this pull request
May 3, 2018
* `parse_package_string()` raises `InvalidPackage` exception with the package name in the message. This work is needed for [https://github.com/ros-infrastructure/rosdep/issues/598](https://github.com/ros-infrastructure/rosdep/issues/598) * Add filename to the InvalidPackage exception coming from `Package.validate()` * `InvalidPackage` has `msg` and`package_path` (#1) `InvalidPackage` exception has `msg`, `package_path` and defines `__str__()` Note that `parse_package_string()` catches `InvalidPackage` exception and sets the filename; it is needed because the functions that called in `_parse_package_string()` raise InvalidPackage exception without filename, e.g. `_get_node()` * Minor code review fixes - Use double quotes for string literals with single quotes inside - Use forward slash instead of backward slash in file path * Pass filename to functions that raise InvalidPackage Remove not used `_get_optional_node_value()` Remove try/except block that was adding filename to InvalidPackage exception * nipick: improve error message
Nickolaim
added a commit
that referenced
this pull request
May 4, 2018
* Enable flake8 for the project as a unit test. The test is copied from [https://github.com/ros-infrastructure/rosdep/blob/d31c5320b95f4e9ff6a0aad56a8531cb138fc079/test/test_flake8.py](https://github.com/ros-infrastructure/rosdep/blob/d31c5320b95f4e9ff6a0aad56a8531cb138fc079/test/test_flake8.py) Code re-formatted, fixed other issues raised by flake8 * Do not run flake8 test on Python 3.2 Add Python 3.6 to Travis CI * keep operator trailing * avoid aligned indentation * avoid aligned indentation * remove unnecessary parenthesis * avoid aligned indentation * remove old comment * conf.py doesn't exist * remove usage of format_map which is not available in Python 2.7 * remove usage of format_map which is not available in Python 2.7 * Include package name in error message (ros-infrastructure#212) * Include package name in error message * Wrapped package name in quotes for consistency * Add support for file attribution of license tag (ros-infrastructure#202) * InvalidPackage with package path (ros-infrastructure#209) * `parse_package_string()` raises `InvalidPackage` exception with the package name in the message. This work is needed for [https://github.com/ros-infrastructure/rosdep/issues/598](https://github.com/ros-infrastructure/rosdep/issues/598) * Add filename to the InvalidPackage exception coming from `Package.validate()` * `InvalidPackage` has `msg` and`package_path` (#1) `InvalidPackage` exception has `msg`, `package_path` and defines `__str__()` Note that `parse_package_string()` catches `InvalidPackage` exception and sets the filename; it is needed because the functions that called in `_parse_package_string()` raise InvalidPackage exception without filename, e.g. `_get_node()` * Minor code review fixes - Use double quotes for string literals with single quotes inside - Use forward slash instead of backward slash in file path * Pass filename to functions that raise InvalidPackage Remove not used `_get_optional_node_value()` Remove try/except block that was adding filename to InvalidPackage exception * nipick: improve error message * Fix flake8 issues (1 empty line instead of 2) for recently updated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvalidPackageexception hasmsg,package_pathand defines__str__()Note that
parse_package_string()catches InvalidPackage exception and setsthe filename; it is needed because the functions that called in
_parse_package_string()raise InvalidPackage exception without filename,e.g.
_get_node()