[Feature] #1241 Do not automatically DOWNLOAD updates in metered networks #1252
Conversation
|
Seems pre-Windows 10 support will be dropped by upgrading to .NET 8.0 |
|
Hello @GopherTheCoder ! Do I need to setup something on my end? |
|
Oh okay...
|
|
Do you mind resolving the conflicts and rebasing (dev)? |
In UserSettings.cs & Settings.xaml: Added Boolean value "DownloadWithMeteredNetwork". In Options.xaml & Options.xaml.cs: Added checkbox in Options binded with the value. In StringResources: Added StringResources description and info, en & zh.
In Other.cs: Added method IsMeteredNetwork, using WinRT API. In ScreenToGif.csproj: Since the API used in method was introduced in Windows 10 (10.0.10240.0), so I have to change projects target OS version. In ApplicationViewModel.cs: Use the method with option value to determine if we download new version automatically.
Did the rebasing, not so familiar with Git, hope I did it right. For the target OS version, I thought the minimum OS version will already be 10.0.17763.0 implictly, as target framework changed to .NET 8.0. Seems that's not the case, still need to explicitly specify that, I see you already did that in dev. Sorry I didn't do a test last time, only merged in Github webUI. I gave it a try locally this time, everything looks good. Is there any proper testing for changes/PRs that I can do? |
I'll do a test manually. Thank you. :) |
|
Hooray to my first ever open source code contribution! |
Hello @NickeManarin ,
I've tried to implement this feature requested in #1241 , but I changed it a bit. Instead of don't check for updates, I only constrained the automatic download of new version.
The method to check if is in metered networks comes from here:
stackoverflow
But there brings a problem.
The WinRT API I used was introduced after Windows 10, so I had to change the target OS version to 10.0.17763.0, which will
likely make the product incompatible with old Windows version.
I'm still trying to find a way to make it version adaptive, any advice would be appreciated.
But for now I still want to create this PR for visibility.
Appreciate your time!