Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unattended execution #62

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Allow unattended execution #62

merged 3 commits into from
Apr 12, 2022

Conversation

jorsmatthys
Copy link
Contributor

  • Add linux commands (WSL & runner tested)
  • Use PAT or GitHub App token for pushing codeql file when CodeScanning is enabled

@jorsmatthys jorsmatthys changed the title tested unattended version allow_unattended_execution Apr 9, 2022
@jorsmatthys jorsmatthys changed the title allow_unattended_execution Allow unattended Execution Apr 9, 2022
@jorsmatthys jorsmatthys changed the title Allow unattended Execution Allow unattended execution Apr 9, 2022
NickLiffen
NickLiffen reviewed Apr 11, 2022
View reviewed changes
src/utils/commitFile.ts Outdated Show resolved Hide resolved
NickLiffen
NickLiffen reviewed Apr 11, 2022
View reviewed changes
src/utils/globals.ts Outdated Show resolved Hide resolved
@NickLiffen
Copy link
Owner

@jorsmatthys small thoughts 👍 PR looks good, just want to clarify some points 👍

@NickLiffen NickLiffen mentioned this pull request Apr 11, 2022
Closed
@NickLiffen
Copy link
Owner

@jorsmatthys can you also run yarn run prettier:write please 🙇

@NickLiffen
Copy link
Owner

Thanks for all your work on this @jorsmatthys 🙇

@jorsmatthys
Copy link
Contributor Author

My pleasure :) I applied the changes.

@NickLiffen
Copy link
Owner

Amazing 🙇 and just checking you have ran the wslLinuxCommands locally and it works for you, correct? could you just send me a screenshot of the commands running over 1 repo so I can see 🙇 Thanks @jorsmatthys I think e can merge it in after that 🙇

@jorsmatthys
Copy link
Contributor Author

jorsmatthys commented Apr 11, 2022 •
edited
Loading

screenshot_multilanguage_workflow
screenshot_multilanguage_workflow_2
screenshot_start_logoutput

Indeed I tested it in WSL 😃 I just ran it again in WSL, npm run getRepos for javascript and then npm run start, the entire log doesn't fit on the screenshot, but I took the most relevant part. I also added screenshots of the workflow I ran in GitHub on an ubuntu-latest runner. The test job collects repos of different languages in turn (1 of each exists) and enables all features and commits a codeql.

Edit: I just reran it with our PAT as well, works as well.

@NickLiffen NickLiffen self-requested a review April 12, 2022 11:57
@NickLiffen NickLiffen merged commit 05be846 into NickLiffen:main Apr 12, 2022
@jorsmatthys jorsmatthys deleted the run-unattended branch June 20, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLiffen NickLiffen NickLiffen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorsmatthys @NickLiffen