[Ansible::Runner] Output Fix ManageIQ#2

For reading "stdout" for the `ansible-runner` invocation, use the
`artifacts/result/job_events/*.json` files instead of the `stdout`,
since they are consistently correct (it seems).

There is some additional sorting and data massaging that is also done to
make sure things are correct (and have been documented in the code
directly), but it is mostly:

- looping through the .json files in the directory
- sorting them to the proper numerical order
- Reading the files and appending them to a string
- Ensuring a new lines exist for each file read

This makes it so that each file's content is on it's own line in the
same format as the `artifacts/result/stdout` that was used previously.

I am pretty sure the downsides to this approach are limited, and the
previous commit should make it so that any non-Hash values potentially
generated from this new code will be a non-issue.

lib/ansible/runner/response.rb

@@ -80,9 +80,41 @@ def load_return_code
         1
       end
 
+      JOB_EVENT_GLOB = %w[artifacts result job_events *.json].freeze
+
       # @return [String] Stdout that is text, where each line should be JSON encoded object
       def load_stdout
-        File.read(File.join(base_dir, "artifacts", ident, "stdout"))
+        "".tap do |stdout|
+          # Dir.glob for all `job_events`, and sort them by the "counter"
+          # integer in the file name, which is the first digit(s) prior to a
+          # '-' in the file.
+          #
+          #   job_events/1-2f97771f-c3d1-4123-8648-d035d48be4e8.json
+          #   job_events/10-6f5dc948-c42f-4f3d-a357-151ec3e0b42e.json
+          #   job_events/11-c0c9fdbe-8a69-4ac8-817b-19b567b514ac.json
+          #   job_events/12-66c5f878-8fdc-4d76-9faf-2b42495a2636.json
+          #   job_events/2-080027c4-9455-90b8-e116-000000000006.json
+          #   job_events/3-080027c4-9455-90b8-e116-00000000000d.json
+          #   ...
+          #
+          # And since `Dir.glob`'s sort order is operating system dependent, we
+          # sort manually by the basename to ensure the proper order, and the
+          # `File.basename` calls are done in a `.sort_by!` up front so they
+          # aren't triggered for each block call in a traditional `.sort!`.
+          #
+          job_event_files = Dir.glob(File.join(base_dir, *JOB_EVENT_GLOB))
+                               .sort_by! {|fname| fname.match(%r{job_events/(\d+)})[1].to_i }
+
+          # Read each file and added it to the `stdout` string.
+          #
+          # Also add a newline after each File read if one doesn't already
+          # exist (`ansible-runner` is inconsistent with it's use of new-lines
+          # at the end of files).
+          job_event_files.each do |filename|
+            stdout << File.read(filename)
+            stdout << "\n" unless stdout[-1] == "\n"
+          end
+        end
       rescue
         _log.warn("Couldn't find ansible-runner stdout in #{base_dir}")
         ""