Skip to content

Commit

Permalink
Use modern Android libc++ in Yoga and React Native OSS (facebook#1412)
Browse files Browse the repository at this point in the history
Summary:
X-link: facebook/react-native#39795
Pull Request resolved: facebook#1412

Android NDK 25 uses a version of libc++ that is more than three years old, missing a lot of basic features of C++ 20. This is rectified in NDK 26 (latest LTS NDK), which brings us up to date with latest Clang (17, released this year), and adds a new policy where future NDK versions will bump libc++ as part of bumping LLVM/Clang.

This requires an a beta AGP version (and corresponding Android Studio Preview). Based on how far we are historically, it wouldn't be a surprise if we see the stable release this month (well before the RN 0.74/Yoga 3.0 cut, even in the worse case).

Changelog:
[Android][Changed] - Use NDK 26

Reviewed By: yungsters

Differential Revision: D49895949

fbshipit-source-id: 0ff69ef8495d67ccf15deaa67576dc2a99a70a02
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Oct 4, 2023
1 parent 2734784 commit 23b53ad
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
*/

plugins {
id("com.android.library") version "8.1.1" apply false
id("com.android.application") version "8.1.1" apply false
id("com.android.library") version "8.2.0-beta06" apply false
id("com.android.application") version "8.2.0-beta06" apply false
id("io.github.gradle-nexus.publish-plugin") version "1.3.0"
}

Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
2 changes: 1 addition & 1 deletion java/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ android {
namespace = "com.facebook.yoga"
compileSdk = 34
buildToolsVersion = "34.0.0"
ndkVersion = "25.1.8937393"
ndkVersion = "26.0.10792818"

defaultConfig {
minSdk = 21
Expand Down

0 comments on commit 23b53ad

Please sign in to comment.