Skip to content

Commit

Permalink
Properly expose jscexecutor as a prefab target (facebook#35521)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#35521

Inside RC3 the jscexecutor target was prepared for prefab consumption
but not properly exposed.
This was not caught by the CI as we're not effectively using this target,
but some of our popular libraries do (i.e. Reanimated). I'm exposing it here.

Changelog:
[Internal] [Changed] - Properly expose `jscexecutor` as a prefab target

Reviewed By: javache

Differential Revision: D41648349

fbshipit-source-id: 1a04bc21aa50eece304828ce1d99ae795a51af48
  • Loading branch information
cortinico authored and facebook-github-bot committed Dec 1, 2022
1 parent 5f01622 commit da4243b
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions ReactAndroid/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -435,8 +435,7 @@ android {
"-DANDROID_TOOLCHAIN=clang",
"-DANDROID_PLATFORM=android-21"

targets "jscexecutor",
"jsijniprofiler",
targets "jsijniprofiler",
"reactnativeblob",
"reactperfloggerjni",
// prefab targets
Expand All @@ -463,7 +462,8 @@ android {
"react_render_uimanager",
"react_render_scheduler",
"react_render_mounting",
"hermes_executor"
"hermes_executor",
"jscexecutor"
}
}
ndk {
Expand Down Expand Up @@ -583,6 +583,9 @@ android {
hermes_executor {
headers(new File(prefabHeadersDir, "hermes_executor").absolutePath)
}
jscexecutor {
headers(new File(prefabHeadersDir, "jscexecutor").absolutePath)
}
}

publishing {
Expand Down

0 comments on commit da4243b

Please sign in to comment.