Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perp): emit MarketUpdatedEvents even in the absence of index price #1606

Merged
merged 5 commits into from
Oct 8, 2023
Merged

fix(perp): emit MarketUpdatedEvents even in the absence of index price #1606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8f62e3
fix(perp): emit MarketUpdatedEvents even in the absence of index price
k-yang Sep 27, 2023
d3b3284
Update CHANGELOG.md
k-yang Sep 27, 2023
6226876
Merge branch 'master' into fix/perp/emit-event-even-without-index-price
k-yang Sep 27, 2023
d2daeb1
Merge branch 'master' into fix/perp/emit-event-even-without-index-price
k-yang Oct 7, 2023
25a3253
chore(perp): emit negative index price when not found
k-yang Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Bump `bufbuild/buf-setup-action` from 1.26.1 to 1.27.0 ([#1624](https://github.com/NibiruChain/nibiru/pull/1624))
- Bump `stefanzweifel/git-auto-commit-action` from 4 to 5 ([#1625](https://github.com/NibiruChain/nibiru/pull/1625))

### Bug Fixes

* [#1606](https://github.com/NibiruChain/nibiru/pull/1606) - fix(perp): emit `MarketUpdatedEvent` in the absence of index price

## [v0.21.10]

### Features
Expand Down
15 changes: 8 additions & 7 deletions x/perp/v2/module/abci.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,19 @@ func EndBlocker(ctx sdk.Context, k keeper.Keeper) []abci.ValidatorUpdate {
continue
}

indexTwap, err := k.OracleKeeper.GetExchangeRateTwap(ctx, amm.Pair)
if err != nil {
k.Logger(ctx).Error("failed to fetch twap index price", "market.Pair", market.Pair, "error", err)
continue
}

if markTwap.IsNil() || markTwap.IsZero() {
k.Logger(ctx).Error("mark price is zero", "market.Pair", market.Pair)
continue
}

if indexTwap.IsNil() || indexTwap.IsZero() {
var indexTwap sdk.Dec
indexTwap, err = k.OracleKeeper.GetExchangeRateTwap(ctx, amm.Pair)
if err != nil {
k.Logger(ctx).Error("failed to fetch twap index price", "market.Pair", market.Pair, "error", err)
indexTwap = sdk.OneDec().Neg()
}

if indexTwap.IsNil() {
k.Logger(ctx).Error("index price is zero", "market.Pair", market.Pair)
continue
}
Expand Down