Skip to content

Commit

Permalink
refactor: add changes to tests to make them independent (#868)
Browse files Browse the repository at this point in the history
* add changes to tests to make them independent

* add other independent test

* update changelog

* include more tests

* finish pr

* fix linter

* remove ordering trick in functions

* remove log line
  • Loading branch information
AgentSmithMatrix authored Sep 7, 2022
1 parent 635dde6 commit d7243af
Show file tree
Hide file tree
Showing 8 changed files with 612 additions and 521 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* [#858](https://github.com/NibiruChain/nibiru/pull/858) - fix trading limit ratio check; checks in both directions on both quote and base assets
* [#865](https://github.com/NibiruChain/nibiru/pull/865) - refactor(vpool): clean up interface for CmdGetBaseAssetPrice to use add and remove as directions
* [#868](https://github.com/NibiruChain/nibiru/pull/868) - refactor dex integration tests to be independent between them

### Features

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ test-sim-benchmark-invariants:
###############################################################################

lint:
docker run -v $(CURDIR):/code -w /code golangci/golangci-lint:v1.47.3-alpine golangci-lint run
docker run -v $(CURDIR):/code --rm -w /code golangci/golangci-lint:v1.47.3-alpine golangci-lint run

.PHONY: \
test-sim-nondeterminism \
Expand Down
12 changes: 6 additions & 6 deletions x/dex/client/cli/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,22 @@ import (
)

const (
// Will be parsed to string.
// FlagPoolFile Will be parsed to string.
FlagPoolFile = "pool-file"

// Will be parsed to uint64.
// FlagPoolId Will be parsed to uint64.
FlagPoolId = "pool-id"

// Will be parsed to []sdk.Coin.
// FlagTokensIn Will be parsed to []sdk.Coin.
FlagTokensIn = "tokens-in"

// Will be parsed to sdk.Coin.
// FlagPoolSharesOut Will be parsed to sdk.Coin.
FlagPoolSharesOut = "pool-shares-out"

// Will be parsed to sdk.Coin.
// FlagTokenIn Will be parsed to sdk.Coin.
FlagTokenIn = "token-in"

// Will be parsed to string.
// FlagTokenOutDenom Will be parsed to string.
FlagTokenOutDenom = "token-out-denom"
)

Expand Down
Loading

0 comments on commit d7243af

Please sign in to comment.