Use stable forms for registration tokens #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://spec.matrix.org/v1.2/client-server-api/#token-authenticated-registration This isn't ready to be used yet because the patch for synapse hasn't been merged (matrix-org/synapse#11867).
|
I think it makes sense to merge this, once the synapse side is merged. Currently we don't really use the versioning at all, we just use the versions of the endpoints that are available. Thank you for taking the initiative! |
|
Well, because this has no tests, we don't even need to bump the synapse version to not break our CI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://spec.matrix.org/v1.2/client-server-api/#token-authenticated-registration
This isn't ready to be used yet because the patch for synapse hasn't been
merged (matrix-org/synapse#11867).
Also I don't know how you're dealing with the new spec versioning so maybe this is annoying.