Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PinServiceMapper 매핑 오류 수정 #150

Merged
merged 1 commit into from
Mar 1, 2024
Merged

PinServiceMapper 매핑 오류 수정 #150

merged 1 commit into from
Mar 1, 2024

Conversation

haeun-i
Copy link
Collaborator

@haeun-i haeun-i commented Mar 1, 2024

개요

PinServiceMapper 매핑 오류를 수정했습니다.

작업사항

  • Pin -> PinRedisRes로 변환하는 과정에서 Pin은 Course를, PinRedisRes는 courseId를 가지고 있는데 이를 매핑하는 로직을 추가하지 않아서 생긴 문제였습니다.
  • Course 조회할 때 pin을 사용해서 CourseServiceMapper에 pin 변환 로직을 추가해 두었었는데, pin과 관련된 로직은 PinServiceMapper에서 처리하는 게 맞는 것 같아 핀 관련 매핑 로직을 PinServiceMapper로 이동시켰습니다.

관련 이슈

@haeun-i haeun-i requested a review from emost22 March 1, 2024 12:26
@haeun-i haeun-i self-assigned this Mar 1, 2024
emost22
emost22 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@emost22 emost22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니디!

@haeun-i haeun-i merged commit 4d9100a into develop Mar 1, 2024
1 check passed
@haeun-i haeun-i deleted the feature/149-mapping branch March 1, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emost22 emost22 emost22 approved these changes

Assignees

@haeun-i haeun-i

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PinServiceMapper 매핑 오류 수정
2 participants
@haeun-i @emost22