Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolti-312 style: BtAppBar 패딩 값 수정 #316

Merged
merged 4 commits into from
Oct 20, 2024
Merged

Boolti-312 style: BtAppBar 패딩 값 수정 #316

merged 4 commits into from
Oct 20, 2024

Conversation

mangbaam
Copy link
Member

Issue

작업 내용

  • 앱바 좌우 패딩 변경
  • resource id 리스트를 받아서 아이콘 표시하는 고수준 컴포저블 작성
  • 템플릿 고민해봤는데 기존 BtAppBarDefaults 로도 충분할 것 같아서 현행 유지함

의견 있으면 주세요

@mangbaam mangbaam added the style UI, 디자인 작업 등 label Oct 19, 2024
@mangbaam mangbaam requested a review from HamBP October 19, 2024 07:16
@mangbaam mangbaam self-assigned this Oct 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 19, 2024 •
edited
Loading

Test Results

 9 files   9 suites   0s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
12 runs  12 ✅ 0 💤 0 ❌

Results for commit b3ceeb6.

♻️ This comment has been updated with latest results.

HamBP
HamBP approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@HamBP HamBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

presentation/src/main/java/com/nexters/boolti/presentation/component/BtAppBar.kt Outdated Show resolved Hide resolved
@mangbaam mangbaam merged commit 2fba0b8 into develop Oct 20, 2024
2 checks passed
@mangbaam mangbaam deleted the feature/Boolti-312 branch October 20, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamBP HamBP HamBP approved these changes

Assignees

@mangbaam mangbaam

Labels
style UI, 디자인 작업 등
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BtAppBar 패딩 값 수정
2 participants
@mangbaam @HamBP