Feature/254 선물하기 flow #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 9 files 9 suites 0s ⏱️ Results for commit 747adba. ♻️ This comment has been updated with latest results. |
getXXX 이지만 멱등하지 않은 것 같아서 변경해유~
HamBP
commented
Jun 25, 2024
presentation/src/main/java/com/nexters/boolti/presentation/component/MainButton.kt
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/screen/Main.kt
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/screen/MainDestination.kt
Show resolved
Hide resolved
| } | ||
|
|
||
| @Composable | ||
| private fun InfoRow( |
There was a problem hiding this comment.
디자인 점점 늘어나면서 이런 형식의 컴포넌트가 어마무시하게 많아지는 것 같아서, 나중에 컴포넌트 따로 정리해야 할 듯
There was a problem hiding this comment.
시간 지나면서 컴포넌트화 할만한 UI 들이 많이 보이니
동의합니다
presentation/src/main/java/com/nexters/boolti/presentation/screen/gift/GiftScreen.kt
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/nexters/boolti/presentation/screen/ticketing/ChooseTicketBottomSheet.kt
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/screen/ticketing/TicketingScreen.kt
Outdated
Show resolved
Hide resolved
...ntation/src/main/java/com/nexters/boolti/presentation/screen/ticketing/TicketingViewModel.kt
Show resolved
Hide resolved
tosspayments/src/main/java/com/nexters/boolti/tosspayments/Constants.kt
Outdated
Show resolved
Hide resolved
tosspayments/src/main/java/com/nexters/boolti/tosspayments/TossPaymentState.kt
Show resolved
Hide resolved
mangbaam
approved these changes
Jul 14, 2024
data/src/main/java/com/nexters/boolti/data/datasource/GiftDataSource.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Composable | ||
| private fun InfoRow( |
There was a problem hiding this comment.
시간 지나면서 컴포넌트화 할만한 UI 들이 많이 보이니
동의합니다
presentation/src/main/java/com/nexters/boolti/presentation/screen/gift/GiftUiState.kt
Show resolved
Hide resolved
...tion/src/main/java/com/nexters/boolti/presentation/screen/giftcomplete/GiftCompleteScreen.kt
Outdated
Show resolved
Hide resolved
...tion/src/main/java/com/nexters/boolti/presentation/screen/giftcomplete/GiftCompleteScreen.kt
Outdated
Show resolved
Hide resolved
| ) | ||
| } | ||
|
|
||
| @Preview(heightDp = 100) |
There was a problem hiding this comment.
회사에서 최상위 함수로 더미데이터 꽂아주는 거 만들어놓고 쓰고 있는데 너무 편해
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
작업 내용
코멘트
미안... 이게 2000줄이 될 줄은 몰랐어...
주목할 만한(?) 코드들에 표시해 둘게
무료 케이스는 별도 이슈로 분리했어.
시연
KakaoTalk_20240626_013610571.mp4