Fix command line argument + un-catched exception #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Awesome project!
I have started to have an issue a few weeks ago where Apple Music will stop being responsive to pause and skip buttons. I am not sure if this is because of this library, so I looked into it.
I cannot consistently reproduce this issue, but the one time I could, I found an error in the logs at the same time:
Looking into the code, it seems
this.rpc.close();
is trusted to not error and any error coming from it is not catched. So in this PR I added atry
block around it. Even if this is not the root cause of my issue, it is still a good idea to catch any errors from this line of code.While running this code locally, I also noticed that it complains about
so I followed the suggestion and used
--allow-hrtime
instead. If this is intended or my system is outdated feel free to let me know and I will revert this change.