Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Bluray/DVD Universal Remote #250

Merged
merged 34 commits into from
Oct 9, 2024
Merged

[IR] Bluray/DVD Universal Remote #250

merged 34 commits into from
Oct 9, 2024

Conversation

jaylikesbunda
Copy link
Contributor

@jaylikesbunda jaylikesbunda commented Oct 7, 2024

What's New

NEW Blu-ray/DVD Universal IR Remote

NEW Remote Icons:

Eject
CC (Closed Captions/Subtitle)
Ok
Fast F
Fast B

New bluray_dvd.ir file with:

Function Signals
Power 40
Eject 24
Play 35
Pause 28
Fast Forward 17
Fast Backward 26
Ok 27
CC 20

Screenshot-20241008-222309

big thanks to @luu176 and @Willy-JL for the help couldn't have made this without them


For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@jaylikesbunda
Copy link
Contributor Author

fbt automatically bumped f7 api_symbols to 73.2 but i manaually bumped f18 to 73.2 to prevent build check error

@Willy-JL
Copy link
Member

Willy-JL commented Oct 8, 2024

fbt automatically bumped f7 api_symbols to 73.2 but i manaually bumped f18 to 73.2 to prevent build check error

yep FBT does that, but since we're not in charge here we must follow OFW API versioning or apps wont work, so we can never update API version independently... i should just disable it automatically changing API version in our FBT

@Willy-JL
Copy link
Member

Willy-JL commented Oct 8, 2024

TODO

  • rework and re-evaluate buttons

they look reasonable to me, only note is that closed captions could use being 2 pixel wide stroke instead of 1. do you also plan to change which buttons are included, like including different functions?

@Willy-JL
Copy link
Member

Willy-JL commented Oct 8, 2024

as far as im concerned this is good to merge, but heard on discord you might want to swap the STOP button. whatever you choose, undraft when ready :D

@Willy-JL Willy-JL added the feature New feature or request label Oct 8, 2024
changed stop to 'ok'
changed next & prev to fast f and fast b
@jaylikesbunda
Copy link
Contributor Author

jaylikesbunda commented Oct 8, 2024

i'm sorry. i genuinely cannot build this, everytime i go to it tells me i'm using fast_f instead of "fast_foward" which was a misspelling and is not listed anywhere and has been renamed everywhere. i have no idea what's going on. everything is done and ready

never give up or something idk

@jaylikesbunda jaylikesbunda marked this pull request as ready for review October 8, 2024 12:30
@Willy-JL
Copy link
Member

Willy-JL commented Oct 8, 2024

i'm sorry. i genuinely cannot build this, everytime i go to it tells me i'm using fast_f instead of "fast_foward" which was a misspelling and is not listed anywhere and has been renamed everywhere. i have no idea what's going on. everything is done and ready

probably due to how i updated your branch. im assuming you added more changes after i had edited the branch, but you had not pulled my changes first. if everything is correct on github, but your local clone is broken, you can try to delete the local branch and clone the remote branch again.

git branch -m temp
git checkout -b dev origin/dev
git branch -D temp

this will rename current branch, checkout the remote branch (you might have to change origin based on your configured remote name), then delete the old branch

Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@Willy-JL Willy-JL merged commit 8348510 into Next-Flip:dev Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants