-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IR] Bluray/DVD Universal Remote #250
Conversation
fbt automatically bumped f7 api_symbols to 73.2 but i manaually bumped f18 to 73.2 to prevent build check error |
yep FBT does that, but since we're not in charge here we must follow OFW API versioning or apps wont work, so we can never update API version independently... i should just disable it automatically changing API version in our FBT |
they look reasonable to me, only note is that closed captions could use being 2 pixel wide stroke instead of 1. do you also plan to change which buttons are included, like including different functions? |
as far as im concerned this is good to merge, but heard on discord you might want to swap the STOP button. whatever you choose, undraft when ready :D |
changed stop to 'ok' changed next & prev to fast f and fast b
never give up or something idk |
probably due to how i updated your branch. im assuming you added more changes after i had edited the branch, but you had not pulled my changes first. if everything is correct on github, but your local clone is broken, you can try to delete the local branch and clone the remote branch again. git branch -m temp
git checkout -b dev origin/dev
git branch -D temp this will rename current branch, checkout the remote branch (you might have to change origin based on your configured remote name), then delete the old branch |
gotta remember to format icons as 1bit BW lmao
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice!
What's New
NEW Blu-ray/DVD Universal IR Remote
NEW Remote Icons:
Eject
CC (Closed Captions/Subtitle)
Ok
Fast F
Fast B
New
bluray_dvd.ir
file with:big thanks to @luu176 and @Willy-JL for the help couldn't have made this without them
For the reviewer