Support heroku-22 stack
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you for adding this. The one thing I also like to keep up to date is the config output in the readme. I will update that, since I'm also going to drop heroku-16 support. |
|
I forgot to answer your question, sorry. I test the buildpacks the same way you did. I don't know of a better way, but I am open to suggestions if there is one. |
I think that the changes in your build script should broadly cover it, i.e. that |
|
(Sorry for my delayed reply!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁 These changes add support for the
heroku-22stack.To test these changes I've successfully deployed some private Heroku apps using the
heroku-22stack that are configured with this buildpack, but am interested to know what else could/would be useful for me to do to validate that these changes will work as expected.