Fix applying parameters to Cloudflare API on GET requests #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cloudflare.py 能否单独checkout 一个分支PR，方便merge |
|
@tongyifan 有空可以review一下 |
|
@NewFuture 好，起床就看 |
tongyifan
approved these changes
Jan 7, 2019
NewFuture
requested changes
Jan 7, 2019
|
See #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, the per-page parameter wasn't passed to Cloudflare API when retrieving DNS records.
Also, it works better when filtering on server-side since pagination hasn't implemented.