Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make timestamps required for SpikeEventSeries #765

Merged
merged 3 commits into from
Dec 19, 2018

Conversation

bendichter
Copy link
Contributor

Motivation

fix NeurodataWithoutBorders/nwb-schema#7

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ?

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #765 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #765   +/-   ##
=======================================
  Coverage   74.63%   74.63%           
=======================================
  Files          60       60           
  Lines        6932     6932           
  Branches     1450     1450           
=======================================
  Hits         5174     5174           
  Misses       1353     1353           
  Partials      405      405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fb82a...4b62138. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #765 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #765   +/-   ##
=======================================
  Coverage   74.63%   74.63%           
=======================================
  Files          60       60           
  Lines        6944     6944           
  Branches     1455     1455           
=======================================
  Hits         5183     5183           
  Misses       1352     1352           
  Partials      409      409

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc2a7bd...61ba149. Read the comment docs.

@ajtritt ajtritt merged commit b851088 into dev Dec 19, 2018
@ajtritt ajtritt deleted the spk_event_series_timestamps branch January 11, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require Timestamps in SpikeEventSeries
2 participants