-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release 3.0 #2015
Draft
stephprince
wants to merge
6
commits into
dev
Choose a base branch
from
release-3.0.0
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Prepare release 3.0 #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1972) * add positional argument warning * update tests to use kwargs * update CHANGELOG.md
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2015 +/- ##
==========================================
+ Coverage 91.69% 92.69% +1.00%
==========================================
Files 27 28 +1
Lines 2708 2710 +2
Branches 707 709 +2
==========================================
+ Hits 2483 2512 +29
+ Misses 149 128 -21
+ Partials 76 70 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* update deprecated classes and methods * update deprecation warnings * update tests for deprecated classes and functions * fix warnings and formatting * add scratch tests and deprecations * keep function behavior for deprecation warnings * update CHANGELOG.md * add tests for deprecations * update scratch tutorial * skip deprecated gallery examples * update CHANGELOG.md * remove old icephys tutorial * add pynwb 4.0 deprecation info * add error on new pass on construct method * remove warnings on construct for deprecations * fix formatting * update hdmf-zarr url * Apply suggestions from code review Co-authored-by: Ryan Ly <[email protected]> * Update src/pynwb/core.py Co-authored-by: Ryan Ly <[email protected]> * add code review suggestions * add catch for extra warning * remove unused variable --------- Co-authored-by: Ryan Ly <[email protected]>
* reconcile io path validator differences * make io and path output the same * update tests for io validation * add test that io and path output is same * update tests for io output with status * add validate helper function and fix status tracking * update arguments and status checks * fix test comparing io and path outputs * update error message for io inputs * add tests to compare all io and path outputs * remove script for testing * add initial json export option * update validator inputs and outputs, remove hdf5io references * update tests for non status output * add tests for json validator output * move pynwb.validate into validation module * update json report * add validation entry point * separate cli and validation function files * update validation tutorial * move get_backend to pynwb init * update example validation for new io behavior * update ruff ignores * fix test comments * update CHANGELOG * add tests for _get_backend * update backend imports for optional zarr * fix test name * update test filename * close io after validation * fix test assertion * add condition for ros3 validation * Update CHANGELOG.md * Apply suggestions from code review Co-authored-by: Ryan Ly <[email protected]> * update cli args and docs * fix formatting * update json-file-path argname * update extension tutorial * Apply suggestions from code review Co-authored-by: Ryan Ly <[email protected]> * warn for positional args in validation --------- Co-authored-by: Ryan Ly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for release of PyNWB 3.0
TODO
Before merging:
dev
.requirements.txt
,requirements-dev.txt
,requirements-doc.txt
,requirements-opt.txt
, andenvironment-ros3.yml
to the latest versions,and update dependency ranges in
pyproject.toml
and minimums inrequirements-min.txt
as needed.Run
pip install pur && pur -r requirements-dev.txt -r requirements.txt -r requirements-opt.txt
and manually update
environment-ros3.yml
.Legal.txt
,license.txt
,README.rst
,docs/source/conf.py
,and any other locations as needed
pyproject.toml
as neededREADME.rst
as neededsrc/pynwb/nwb-schema
submodule as needed. Check the version number and commit SHAmanually. Make sure we are using the latest release and not the latest commit on the
main
branch.CHANGELOG.md
and any other docs as needed(
python test.py -v -p -i -b -w -r > out.txt 2>&1
). Try to remove all warnings.cd docs; make clean && make html
branch by going to https://github.com/NeurodataWithoutBorders/pynwb/actions/workflows/run_all_tests.yml, selecting
"Run workflow" on the right, selecting this branch, and clicking "Run workflow". Make sure all tests pass.
After merging:
docs/source/make_a_release.rst
or use aliasgit pypi-release [tag]
if set upGitHub releases page with the changelog
regro-cf-autotick-bot bot to create a PR updating the version of HDMF to the latest PyPI release, usually within
24 hours of release, or manually create a PR updating
recipe/meta.yaml
with the latest version numberand SHA256 retrieved from PyPI > PyNWB > Download Files > View hashes for the
.tar.gz
file. Re-render and updatedependencies as needed.