Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel_conversion use in TimeSeries.get_data_in_units #1923

Conversation

rohanshah
Copy link
Contributor

@rohanshah rohanshah commented Jun 24, 2024

Motivation

Fixes issue discussed here: NeurodataWithoutBorders/helpdesk#83

How to test the behavior?

Updated unit test to reflect functional change

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@bendichter bendichter self-requested a review June 24, 2024 16:43
Copy link
Contributor

@bendichter bendichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rohanshah
Copy link
Contributor Author

thanks @bendichter ! no rush on my end but what's the best way to have this merged and into the next release?

@bendichter bendichter enabled auto-merge (squash) June 26, 2024 17:51
@bendichter
Copy link
Contributor

@rohanshah I'm running tests now. If/when those pass, it'll automatically be merged to dev and will be incorporated in the next release

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (90e6048) to head (be5c08c).
Report is 21 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1923   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files          27       27           
  Lines        2651     2651           
  Branches      692      692           
=======================================
  Hits         2436     2436           
  Misses        142      142           
  Partials       73       73           
Flag Coverage Δ
integration 72.80% <0.00%> (ø)
unit 83.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter bendichter merged commit 9a46106 into NeurodataWithoutBorders:dev Jun 26, 2024
23 of 24 checks passed
@rohanshah rohanshah deleted the fix/get-data-in-units-channel-conversion branch June 26, 2024 19:08
@rly
Copy link
Contributor

rly commented Jun 26, 2024

Thanks for the bug fix @rohanshah !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants