-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grid_spacing
and origin_coords
to the fields of ImagingPlane
#1892
Add grid_spacing
and origin_coords
to the fields of ImagingPlane
#1892
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1892 +/- ##
=======================================
Coverage 92.01% 92.01%
=======================================
Files 27 27
Lines 2619 2619
Branches 685 685
=======================================
Hits 2410 2410
Misses 139 139
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@h-mayorquin I think you were missing a comma in the |
My bad, I tested your change and it is working now. Thanks. Added the changelog. |
Thanks for the fix @h-mayorquin ! |
Motivation
This should fix #1885
I discussed this with @rly and it seems that it was just an omission. This PR tries to address this. So far, this seems to work for
grid_spacing
but for some reason that escapes me it seems thatorigin_coords
is not added to the fields.Checklist
flake8
from the source directory.