Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zarr IO tutorial #1834

Merged
merged 12 commits into from
Jan 29, 2024
Merged

Add Zarr IO tutorial #1834

merged 12 commits into from
Jan 29, 2024

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Jan 25, 2024

Motivation

fix #1832

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c6868b) 91.99% compared to head (588c96b) 91.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1834   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          27       27           
  Lines        2623     2623           
  Branches      685      685           
=======================================
  Hits         2413     2413           
  Misses        138      138           
  Partials       72       72           
Flag Coverage Δ
integration 71.10% <ø> (ø)
unit 83.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 88 to 89
# For more information, see the :hdmf-zarr:`hdmf-zarr documentation<>`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this a callout .. note:: and also point to the NWB specific tutorials in addition to the general hdmf-zarr docs.

Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this tutorial. I added a couple of minor suggestions, but overall this looks good to me.

oruebel
oruebel previously approved these changes Jan 26, 2024
rly
rly previously approved these changes Jan 26, 2024
rly
rly previously approved these changes Jan 26, 2024
@bendichter bendichter merged commit 9c87ffd into dev Jan 29, 2024
24 checks passed
@bendichter bendichter deleted the docs_zarr_tutorial branch January 29, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: Need tutorial for writing in Zarr
3 participants