Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx-gallery settings to support version >=0.11 #1733

Merged
merged 2 commits into from
Jul 23, 2023

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Jul 23, 2023

Motivation

Add 'nested_sections': False setting for sphinx-gallery to force using the orginial behavior for generating the page index to allow us to use the latest versions of sphinx-gallery (>=0.11) instead of having to fix the version to 0.10.1

This PR reverts the changes from #1728 such that the version of sphinx-gallery is no longer fixed.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #1733 (45a1bc7) into dev (c881c68) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1733   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files          27       27           
  Lines        2602     2602           
  Branches      680      680           
=======================================
  Hits         2393     2393           
  Misses        134      134           
  Partials       75       75           
Flag Coverage Δ
integration 71.32% <ø> (ø)
unit 83.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oruebel oruebel requested a review from bendichter July 23, 2023 08:53
@rly rly merged commit b183e83 into dev Jul 23, 2023
@rly rly deleted the up/support_latest_sphinx_gallery branch July 23, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants