Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests with invalid test data that will be caught by future hdmf validator version #1366

Merged
merged 4 commits into from
Jun 25, 2021
Merged

Fix integration tests with invalid test data that will be caught by future hdmf validator version #1366

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
514ffb1
Fix unit tests with invalid test data
dsleiter Jun 9, 2021
77c924f
Update changelog
dsleiter Jun 9, 2021
c7e6bd8
Merge branch 'dev' into bug/fix_tests_for_validator_update
dsleiter Jun 23, 2021
8b42a94
Merge branch 'dev' into bug/fix_tests_for_validator_update
rly Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# PyNWB Changelog

## Upcoming

## Bug fix:
- Fix integration tests with invalid test data that will be caught by future hdmf validator version. @dsleiter (#1366)

## PyNWB 1.5.1 (May 24, 2021)

## Bug fix:
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/hdf5/test_ecephys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def make_electrode_table(self):
location='tetrode location',
device=self.dev1)
for i in range(4):
self.table.add_row(x=i, y=2.0, z=3.0, imp=-1.0, location='CA1', filtering='none', group=self.group,
self.table.add_row(x=float(i), y=2.0, z=3.0, imp=-1.0, location='CA1', filtering='none', group=self.group,
group_name='tetrode1')

def setUpContainer(self):
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def test_append(self):
self.assertIs(nwb.processing['test_proc_mod']['LFP'].electrical_series['test_es'].electrodes,
nwb.acquisition['timeseries2'].electrodes)
errors = validate(io)
self.assertTrue(len(errors) == 0)
self.assertEqual(len(errors), 0, errors)
rly marked this conversation as resolved.
Show resolved Hide resolved


class TestH5DataIO(TestCase):
Expand Down