Update schema to 2.2.4 #1213
Merged
Update schema to 2.2.4 #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oruebel
previously approved these changes
Mar 27, 2020
* change imaging_rate to be optional * use kwargs for all the ImagingPlane tests * more kwargs * update ophys tutorial * flake8 Co-authored-by: Ryan Ly <[email protected]>
bendichter
previously approved these changes
Apr 27, 2020
|
@oruebel @ajtritt @bendichter This is good to go and should be the last PR before the release of PyNWB 1.3.1. |
oruebel
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current release of PyNWB, version 1.3.0, supports nwb-schema version 2.2.2. This PR adds support for nwb-schema bugfix version 2.2.3 and 2.2.4.
This PR tracks the dev branch of nwb-schema to ensure that changes in nwb-schema are compatible with PyNWB or are accompanied with corresponding changes in PyNWB. Those changes in PyNWB should be merged into this branch.
nwb-schema changelog:
ImagingPlane.imaging_rateoptional to handle cases where an imaging plane is associated with multiple time series with different rates.TODO:
cd src/pynwb/nwb-schema/,git pull origin dev,git fetch --tags,git checkout [new_release],cd ../../.., git add, commit, and pushWhen the new version of nwb-schema is released, this branch should be merged into dev without squashing commits.