Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugged Device constructor #1209

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Fix bugged Device constructor #1209

merged 2 commits into from
Mar 18, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Mar 18, 2020

Fix #1208

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #1209 into dev will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1209      +/-   ##
==========================================
+ Coverage   67.97%   68.01%   +0.04%     
==========================================
  Files          37       37              
  Lines        2398     2401       +3     
  Branches      423      423              
==========================================
+ Hits         1630     1633       +3     
  Misses        697      697              
  Partials       71       71              
Impacted Files Coverage Δ
src/pynwb/device.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929972d...40f8eb7. Read the comment docs.

@rly rly merged commit 12b0d18 into dev Mar 18, 2020
@rly rly deleted the fix/device branch March 18, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device class does not set description or manufacturer
2 participants