Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper file removal in tests #1165

Merged
merged 4 commits into from
Feb 4, 2020
Merged

Use proper file removal in tests #1165

merged 4 commits into from
Feb 4, 2020

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Jan 30, 2020

See cc3aef3

@t-b t-b requested a review from rly January 30, 2020 15:33
oruebel
oruebel previously approved these changes Jan 30, 2020
View reviewed changes
rly
rly requested changes Jan 30, 2020
View reviewed changes
tests/unit/test_file.py Outdated Show resolved Hide resolved
tests/unit/test_file.py Outdated Show resolved Hide resolved
@rly
Copy link
Contributor

rly commented Jan 30, 2020

Under tests/integration/hdf5/test_base.py, in TestTimeSeriesLinking.test_timestamps_linking, the created file is not removed. Can you remove that one as well? I've been meaning to do it, but it fits nicely in this PR.

@t-b t-b force-pushed the use-proper-file-removal-in-tests branch from ec1afa9 to 9946db0 Compare January 30, 2020 18:00
@t-b
Copy link
Collaborator Author

t-b commented Jan 30, 2020

@rly Thanks for the review. Done.

rly
rly previously approved these changes Jan 30, 2020
View reviewed changes
t-b added 3 commits January 30, 2020 20:23
@t-b
Tests: Use helper function to remove intermediate NWB files
6502d98 
For debugging it is convenient to use remove_test_file which can be
skipped by setting `CLEAN_NWB=0`.
@t-b
tests/integration/hdf5/test_base.py: Use helper function to remove in…
32e3d60 
…termediate NWB files

This was forgotten earlier.
@t-b
docs/source/getting_started.rst: Mention CLEAN_NWB and CLEAN_HDMF
93db416 
This should be easy to find.
@t-b t-b force-pushed the use-proper-file-removal-in-tests branch from 9946db0 to 93db416 Compare January 30, 2020 19:23
@rly rly merged commit d163f24 into NeurodataWithoutBorders:dev Feb 4, 2020
@t-b t-b deleted the use-proper-file-removal-in-tests branch February 4, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rly rly rly approved these changes

@oruebel oruebel oruebel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-b @rly @oruebel