Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test runner double printing in non-verbose mode #1158

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Fix test runner double printing in non-verbose mode #1158

merged 2 commits into from
Jan 27, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 23, 2020

When running python test.py not in verbose mode, the ColoredTestRunner double printed test result outputs, i.e., the '.', 'F', 'E', and 's'. 172 unit tests generated 344 '.'s. This PR fixes that.

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #1158 into dev will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #1158      +/-   ##
=========================================
- Coverage   68.09%     68%   -0.09%     
=========================================
  Files          37      37              
  Lines        2282    2285       +3     
  Branches      398     399       +1     
=========================================
  Hits         1554    1554              
- Misses        659     662       +3     
  Partials       69      69
Impacted Files Coverage Δ
src/pynwb/ophys.py 94.26% <ø> (ø) ⬆️
src/pynwb/validate.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e33c3...006122c. Read the comment docs.

@rly rly requested a review from ajtritt January 27, 2020 18:17
@rly rly merged commit a41eaee into dev Jan 27, 2020
@rly rly deleted the fix/testrunner branch January 27, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants