Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unittest2 dependency #1142

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Remove unittest2 dependency #1142

merged 3 commits into from
Jan 16, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 16, 2020

Python 2 will no longer be supported, so we can remove the dependency and usage of unittest2 and traceback2. This helps break up the mega PR #1117

@rly rly requested a review from bendichter January 16, 2020 00:44
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #1142 into dev will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1142      +/-   ##
==========================================
+ Coverage   67.49%   67.83%   +0.34%     
==========================================
  Files          38       38              
  Lines        2301     2279      -22     
  Branches      397      397              
==========================================
- Hits         1553     1546       -7     
+ Misses        679      664      -15     
  Partials       69       69
Impacted Files Coverage Δ
src/pynwb/validate.py 0% <ø> (ø) ⬆️
src/pynwb/retinotopy.py 100% <100%> (+5.12%) ⬆️
src/pynwb/ophys.py 94.26% <100%> (+1.46%) ⬆️
src/pynwb/misc.py 85.08% <100%> (+1.32%) ⬆️
src/pynwb/file.py 71.37% <100%> (+0.45%) ⬆️
src/pynwb/image.py 93.54% <100%> (+2.77%) ⬆️
src/pynwb/base.py 92% <100%> (+1.37%) ⬆️
src/pynwb/ecephys.py 96.07% <100%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2897b19...f17a259. Read the comment docs.

@rly rly merged commit bc9254b into dev Jan 16, 2020
@rly rly deleted the rm/unittest2 branch January 16, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants