Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/dtselect #1106

Merged
merged 6 commits into from
Nov 19, 2019
Merged

Enh/dtselect #1106

merged 6 commits into from
Nov 19, 2019

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Nov 14, 2019

Motivation

This is the matching PR for hdmf-dev/hdmf#191 The selection behavior of DynamicTable and DynamicTableRegion has changed in HDMF to return Pandas DataFrames. This updates the tests in PyNWB to conform with the new changes/

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number?

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #1106 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #1106   +/-   ##
=====================================
  Coverage   67.3%   67.3%           
=====================================
  Files         38      38           
  Lines       2288    2288           
  Branches     394     394           
=====================================
  Hits        1540    1540           
  Misses       679     679           
  Partials      69      69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1080cd...8f90295. Read the comment docs.

@oruebel oruebel merged commit bc56a51 into dev Nov 19, 2019
@oruebel oruebel deleted the enh/dtselect branch November 19, 2019 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants