add warning #1098
Merged
add warning #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oruebel
previously approved these changes
Oct 24, 2019
bendichter
reviewed
Oct 24, 2019
|
other than that looks good |
Co-Authored-By: Ben Dichter <[email protected]>
Codecov Report
@@ Coverage Diff @@
## dev #1098 +/- ##
=========================================
- Coverage 67.4% 67.35% -0.06%
=========================================
Files 38 38
Lines 2289 2291 +2
Branches 393 394 +1
=========================================
Hits 1543 1543
- Misses 677 679 +2
Partials 69 69
Continue to review full report at Codecov.
|
oruebel
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
add warning when referencing electrode table before it exists
relates to #1097