Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logo #1096

Merged
merged 3 commits into from
Oct 18, 2019
Merged

Update logo #1096

merged 3 commits into from
Oct 18, 2019

Conversation

rly
Copy link
Contributor

@rly rly commented Oct 17, 2019

Fix #1095

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #1096 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #1096   +/-   ##
=====================================
  Coverage   67.4%   67.4%           
=====================================
  Files         38      38           
  Lines       2289    2289           
  Branches     393     393           
=====================================
  Hits        1543    1543           
  Misses       677     677           
  Partials      69      69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62f52e...c37b45a. Read the comment docs.

@rly
Copy link
Contributor Author

rly commented Oct 17, 2019

The failing gallery35 test appears to be due to an issue with the latest pytables released yesterday, which does not provide wheels for Python 3.5 and therefore does not bundle hdf5.

Collecting tables>=3.5.1
  Downloading https://files.pythonhosted.org/packages/fb/b6/f7128895d328f64e52f61fbb39c03a458f8b583724705bddae392a1085a0/tables-3.6.0.tar.gz (7.8MB)
    ERROR: Command errored out with exit status 1:
     command: /home/circleci/project/.tox/gallery-py35/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-lu4c0l_r/tables/setup.py'"'"'; __file__='"'"'/tmp/pip-install-lu4c0l_r/tables/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-lu4c0l_r/tables/pip-egg-info
         cwd: /tmp/pip-install-lu4c0l_r/tables/
    Complete output (8 lines):
    /usr/bin/ld: cannot find -lhdf5
    collect2: error: ld returned 1 exit status
    * Using Python 3.5.7 (default, Jun 19 2019, 02:10:09)
    * USE_PKGCONFIG: True
    .. ERROR:: Could not find a local HDF5 installation.
       You may need to explicitly state where your local HDF5 headers and
       library can be found by setting the ``HDF5_DIR`` environment
       variable or by using the ``--hdf5`` command-line option.

@rly
Copy link
Contributor Author

rly commented Oct 17, 2019

I filed an issue on PyTables here: PyTables/PyTables#773

For now, I say we push this PR through and note that the gallery35 test will keep failing unless we pin PyTables 3.5 or PyTables releases wheels for Python 3.5 that include hdf5.

@rly rly merged commit 96bc559 into dev Oct 18, 2019
@rly rly deleted the update_logo branch October 18, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new logo to docs
2 participants