Make setup.py require the latest pinned version of HDMF #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rly
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #1083 +/- ##
=======================================
Coverage 67.39% 67.39%
=======================================
Files 38 38
Lines 2288 2288
Branches 393 393
=======================================
Hits 1542 1542
Misses 677 677
Partials 69 69Continue to review full report at Codecov.
|
ajtritt
approved these changes
Oct 7, 2019
oruebel
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
All future releases of PyNWB will require HDMF>=1.3.2 (where generic types moved from PyNWB to HDMF), but
setup.pycurrently does not specify which version of HDMF is required. If a user upgrades to the latest PyNWB (1.1.0), the version of HDMF that they are using must also be upgraded, but this is currently not happening.This PR puts into
setup.pya requirement to use the release of HDMF that is pinned inrequirements.txt(currently 1.3.2). This is almost always the latest version of HDMF.This PR will also prevent another issue where a user has the latest release of PyNWB and the latest release of HDMF but these two versions are incompatible with each other, as they are currently (see #1071 (comment)).