Enhance icephys example and documentation #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple users requested clarification on what we understand under the word "Sweep". Add and explanation so that we can point users to it.
Bug introduced in fe3d760 (add skip to ensure __getitem__ gets documented, 2018-02-09).
- Don't use two timeseries with differnt clamp modes being part of one sweep. This just does not happen experimentally. - Add another set of timeseries to have data from multiple sweeps in the file - Enhance the explanation for the sweep table and move it to the bottom - Use a context manager for writing the NWB file to give a good example - Fix some typos
t-b
changed the title
|
@rly Ready :) |
rly
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rly Ready to merge.