Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing invalid time intervals #1069

Merged
merged 5 commits into from
Sep 17, 2019
Merged

Fix missing invalid time intervals #1069

merged 5 commits into from
Sep 17, 2019

Conversation

rly
Copy link
Contributor

@rly rly commented Sep 17, 2019

Fix #1068

@rly rly requested review from ajtritt and oruebel September 17, 2019 07:14
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #1069 into dev will decrease coverage by 0.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1069      +/-   ##
==========================================
- Coverage   71.16%   71.15%   -0.02%     
==========================================
  Files          37       37              
  Lines        2792     2794       +2     
  Branches      554      554              
==========================================
+ Hits         1987     1988       +1     
- Misses        679      680       +1     
  Partials      126      126
Impacted Files Coverage Δ
src/pynwb/io/base.py 28% <0%> (-0.58%) ⬇️
src/pynwb/io/file.py 75.2% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 425dc57...acedd2a. Read the comment docs.

@rly rly merged commit 7bd72bb into dev Sep 17, 2019
@rly rly deleted the fix/map_missing branch September 17, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid times not being saved
3 participants