-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Pickle TypeMap #1050
[WIP] Pickle TypeMap #1050
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1050 +/- ##
=========================================
- Coverage 71.17% 67.4% -3.78%
=========================================
Files 37 37
Lines 2793 2807 +14
Branches 554 557 +3
=========================================
- Hits 1988 1892 -96
- Misses 679 789 +110
Partials 126 126
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #1050 +/- ##
=========================================
- Coverage 71.17% 67.4% -3.78%
=========================================
Files 37 37
Lines 2793 2807 +14
Branches 554 557 +3
=========================================
- Hits 1988 1892 -96
- Misses 679 789 +110
Partials 126 126
Continue to review full report at Codecov.
|
|
||
def _dec(cls): | ||
__rct_kwargs.append({'data_type': neurodata_type, 'namespace': namespace, 'container_cls': cls}) | ||
return cls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above code will not work with extensions that call register_class
. This will add kwargs to __rct_kwargs
but they are not registered into the __TYPE_MAP
. Same for the register_map
method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch... back to the drawing board.
Motivation
Currently, it takes about 2.5 seconds to PyNWB. Pickling the TypeMap on build/install will help bring this down.
This is WIP to make sure it works with testing/deployment
@dorukozturk @jcfr Your thoughts/input on this would be greatly appreciated.
How to test the behavior?
Run test suite
Checklist
flake8
from the source directory.#XXX
notation whereXXX
is the issue number ?