Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning if name/notes supplied when adding Container to scratch #1038

Merged
merged 9 commits into from
Aug 20, 2019

Conversation

rly
Copy link
Contributor

@rly rly commented Aug 6, 2019

Raise warning if name/notes supplied when adding Container to scratch (they are ignored), and add tests.

@ajtritt table_description appears not to be used in add_scratch?

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #1038 into dev will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1038      +/-   ##
==========================================
- Coverage   71.37%   71.22%   -0.16%     
==========================================
  Files          37       37              
  Lines        2774     2780       +6     
  Branches      547      550       +3     
==========================================
  Hits         1980     1980              
- Misses        670      676       +6     
  Partials      124      124
Impacted Files Coverage Δ
src/pynwb/core.py 73.49% <ø> (ø) ⬆️
src/pynwb/file.py 71.03% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ecefca...b2a63d8. Read the comment docs.

@rly rly requested a review from ajtritt August 6, 2019 19:05
Copy link
Member

@ajtritt ajtritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

tests/integration/ui_write/test_scratch.py Outdated Show resolved Hide resolved
src/pynwb/file.py Outdated Show resolved Hide resolved
@rly rly requested a review from ajtritt August 20, 2019 21:21
@rly rly merged commit cec1fbb into dev Aug 20, 2019
@rly rly deleted the enh/improve_scratch branch August 20, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants